Skip to content

Conversation

@amit1rrr
Copy link
Owner

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@amit1rrr amit1rrr changed the base branch from master to gitplus-d0u8o923 March 30, 2020 13:30
@amit1rrr amit1rrr changed the base branch from gitplus-d0u8o923 to tests March 30, 2020 13:48
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

"metadata": {},
"source": [
"<!--BOOK_INFORMATION-->\n",
"<img align=\"left\" style=\"padding-right:10px;\" src=\"figures/PDSH-cover-small.png\">\n",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

@amit1rrr amit1rrr changed the base branch from tests to from-gitplus-ozcl3827 March 30, 2020 13:51
@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

SandroGH commented on 2020-03-30T13:51:52Z
----------------------------------------------------------------

Test comment


Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

"metadata": {},
"source": [
"<!--BOOK_INFORMATION-->\n",
"<img align=\"left\" style=\"padding-right:10px;\" src=\"figures/PDSH-cover-small.png\">\n",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

@amit1rrr amit1rrr changed the base branch from from-gitplus-ozcl3827 to v2-from-gitplus-ozcl3827 March 30, 2020 14:05
@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

amit1rrr commented on 2020-03-30T14:09:42Z
----------------------------------------------------------------

Test comment - 4


Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

"metadata": {},
"source": [
"<!--BOOK_INFORMATION-->\n",
"<img align=\"left\" style=\"padding-right:10px;\" src=\"figures/PDSH-cover-small.png\">\n",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

@amit1rrr amit1rrr changed the base branch from v2-from-gitplus-ozcl3827 to v3-from-gitplus-ozcl3827 March 30, 2020 14:13
@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

amit1rrr commented on 2020-03-30T14:18:39Z
----------------------------------------------------------------

Test comment - v5

No additional "v5change --"


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

amit1rrr commented on 2020-03-30T14:21:01Z
----------------------------------------------------------------

Test comment - v5

No additional "v5change --"


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants